Allow Requests.Response to be used as a context manager #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves having to wrap the call to requests with
`contextlib.closing()`, allowing it to be used directly in a
`with` statement, like so:
```
with requests.get('http://httpbin.org/get', stream=True) as r:
# Do things with the response here.
```
Fixes psf#4136.
edmorley
force-pushed
the
response-context-manager
branch
from
008ab2c
to
4847f5b
Compare
|
FYI, @kennethreitz, as you can see here the master branch is failing on the Windows builder. @requests/core for the moment we can ignore that failing Windows test and continue to merge until @kennethreitz works out what's going on with the builder. ;) |
Lukasa
approved these changes
Jun 7, 2017
edmorley
referenced
this pull request
in mozilla/treeherder
Feb 12, 2019
Since `requests` has native support for being used as a context manager as of v2.18.0: https://github.com/kennethreitz/requests/pull/4137
edmorley
referenced
this pull request
in mozilla/treeherder
Feb 12, 2019
Since `requests` has native support for being used as a context manager as of v2.18.0: https://github.com/kennethreitz/requests/pull/4137
valgur
added a commit
to valgur/sentinelsat
that referenced
this pull request
May 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves having to wrap the call to requests with
contextlib.closing(), allowing it to be used directly in awithstatement, like so:Fixes #4136.