Fix: update notification not working for minor updates

psi-4ward · Mar 27, 2020 · 48b6e2d · 48b6e2d
1 parent 0cbbebc
commit 48b6e2d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/ui/package-lock.json b/ui/package-lock.json
diff --git a/ui/package.json b/ui/package.json
@@ -16,6 +16,7 @@
     "file-saver": "^2.0.2",
     "highcharts": "^7.1.3",
     "quasar": "^1.9.10",
+    "semver-compare": "^1.0.0",
     "vue": "^2.6.11",
     "vue-router": "^3.1.6"
   },

diff --git a/ui/src/views/Info.vue b/ui/src/views/Info.vue
@@ -168,6 +168,7 @@
 </template>
 
 <script>
+  import semverCompare from 'semver-compare';
   import FlagChip from '../components/FlagChip';
 
   export default {
@@ -198,9 +199,7 @@
           const res = await fetch('https://api.github.com/repos/psi-4ward/AskSinAnalyzerXS/releases/latest');
           const latestVersion = (await res.json()).tag_name;
           const currentVersion = this.$root.version;
-          const [aU, aL] = latestVersion.split('.');
-          const [bU, bL] = currentVersion.split('.');
-          if (aU > bU || aU === bU && aL > bL) {
+          if (semverCompare(latestVersion, currentVersion)) {
             this.updateVersion = latestVersion;
           }
         }