Get rid of "?" buttons in windows titles

[Neustradamus]

Some windows have "?" but it is nothing.

It is possible to remove it?

• Useful Tips
• About
• About ... Plugin
• Psi+: Proxy Profiles
• Secret Key
• Psi+ Import history
• Psi+: Delete Profile
• Psi+: Key Storage Diagnostic Text
• Psi+: Manage Profiles
• Psi+: New Profile
• Psi+: Open Profile
• Psi+: Proxy Profiles
• Psi+: ReadMe
• Psi+: Rename Profile
• Psi+: Security Plugins Diagnostic Text
• Iconset Details
• ...

[Ri0n]

I guess it's about Qt::WindowContextHelpButtonHint

[Ri0n]

It seems removing this button is something complicated and not standard.
see this https://stackoverflow.com/questions/41585596/remove-windowsystemmenuhint-from-qdialog-in-qt for more details.

I'd prefer not to change anything until it really hurts someone.

[Ri0n]

It seems there is a bug in Qt which prevents Qt::AA_DisableWindowContextHelpButton to be working.
While we still can investigate it more deeply, it's a good idea to just report to Qt.

[Neustradamus]

Can you reopen this ticket ?
It is not close yet, I will not create a new for this...
Verified with Qt 5.10.x and Qt 5.12.x

Please remove Qt::WindowContextHelpButtonHint from:

• https://github.com/psi-im/psi/blob/master/src/accountadddlg.cpp
• https://github.com/psi-im/psi/blob/master/src/profiledlg.cpp
• https://github.com/psi-im/psi/blob/master/src/proxy.cpp
• https://github.com/psi-im/psi/blob/master/src/options/optionsdlgbase.cpp
• https://github.com/psi-im/psi/blob/master/src/accountmodifydlg.cpp

[Ri0n]

Last time I checked this Qt::WindowContextHelpButtonHint wa set properly everywhere.

[Ri0n]

@tehnick , note you will have to remove all WhatsThis also to do this properly.

[tehnick]

I propose to move all help data from WhatsThis to ToolTips and get rid of "?" buttons in windows titles. Because WhatsThis functionality is unintuitive for end users and completely contradicts to modern UI ergonomics.

[Ri0n]

I'm fine with that.

[tehnick]

BTW, a quotation from Qt docs:
Qt::AA_DisableWindowContextHelpButton -- Disables the WindowContextHelpButtonHint by default on Qt::Sheet and Qt::Dialog widgets. This hides the ? button on Windows, which only makes sense if you use QWhatsThis functionality. This value was added in Qt 5.10. In Qt 6, WindowContextHelpButtonHint will not be set by default.

So it is really time stop usage of WhatsThis.

[Neustradamus]

Qt::AA_DisableWindowContextHelpButton disables the default option but not if it is configured in code like:

• Get rid of "?" buttons in windows titles #367 (comment)

Normally after it, there will be no more "?".
Example: "About" window
If always here, the Qt::AA_DisableWindowContextHelpButton is not configured for all.

Qt.io doc: https://doc.qt.io/qt-5/qt.html
Qt::AA_DisableWindowContextHelpButton

• 30
• Disables the WindowContextHelpButtonHint by default on Qt::Sheet and Qt::Dialog widgets.
  This hides the ? button on Windows, which only makes sense if you use QWhatsThis functionality.
  This value was added in Qt 5.10.
  In Qt 6, WindowContextHelpButtonHint will not be set by default.

[Neustradamus]

Please note that AA_DisableWindowContextHelpButton removes "?" from window which has by default but if Qt::WindowContextHelpButtonHint is specified, it does not remove it.

[Neustradamus]

Linked to:

• Minimize/Maximize buttons are missing for goupchat history #122
• Conference Logger Plugin - bugs and wishes psi-plus/main#203
• Minimize/Maximize buttons are missing for goupchat history psi-plus/main#642

[Neustradamus]

Examples of screenshots:

• https://image.ibb.co/cQTzoJ/psi-about-window.png
• https://image.ibb.co/eQzHay/psi-readme-window.png
• https://image.ibb.co/crRKoJ/psi-useful-tips-window.png
• https://image.ibb.co/mcu5TJ/psi-key-storage-diagnostic-text-window.png
• https://image.ibb.co/iovC8J/psi-security-plugins-diagnostic-text-window.png
• https://image.ibb.co/b0p5TJ/psi-about-plugin-window.png

[Neustradamus]

Any news after more 1,5 years?

[tehnick]

Yep, this PR should be closed.

[Neustradamus]

No, there are always "?" in dialog for nothing!

[tehnick]

1. 988e890
2. b72147d
3. psi-plus/main@73b0fcb

[tehnick]

4. c9f37c0

[tehnick]

Ok, some dialogs are not fixed yet...

[19:30:05] <Neustradamus> Tehnick: Examples:
About
Psi+: ReadMe
Psi+: Security Plugins Diagnostic Text
Psi+: Proxy Profiles
Secret Key
Psi+: Key Storage Diagnostic Text
About "Module Name" Plugin
Room configuration
Template editor
MUC room history (and always no minimize/maximize window buttons)

[Neustradamus]

@tehnick: Any news?

[tehnick]

@Neustradamus No.

[Neustradamus]

I forgot, several windows, all are:

• About
• About "Module Name" Plugin
• Edit template
• Execute Command
• File Transfer
• Iconset Details
• MUC room log history (and always no minimize/maximize window buttons)
• Psi+ Import history
• Psi+: Delete Profile
• Psi+: Key Storage Diagnostic Text
• Psi+: Manage Profiles
• Psi+: New Profile
• Psi+: Open Profile
• Psi+: Proxy Profiles
• Psi+: ReadMe
• Psi+: Rename Profile
• Psi+: Security Plugins Diagnostic Text
• Room configuration
• Secret Key
• Server Authentication
• Server Settings (for Screenshot plugin)
• Set GeoLocation
• Set Mood
• Stop Spam log history (and always no minimize/maximize window buttons)
• User Activity
• Template editor
• XML Input

[Neustradamus]

@tehnick:

• https://forum.qt.io/topic/50911/hide-windowminimizebutton-of-the-windowtitlebar

By using following code, I can hide the HelpButton:
@ setWindowFlags(((this->windowFlags() | Qt::CustomizeWindowHint)
& ~Qt::WindowContextHelpButtonHint));@
This works fine, too.

• https://forum.qt.io/topic/31425/solved-remove-what-s-this-from-qdialog

dialog->setWindowFlags(dialog->windowFlags() & ~Qt::WindowContextHelpButtonHint);

• https://ios.developreference.com/article/27534481/How+can+I+hide+delete+the+%E2%80%9C%3F%E2%80%9D+help+button+on+the+%E2%80%9Ctitle+bar%E2%80%9D+of+a+Qt+Dialog%3F

• https://stackoverflow.com/questions/2968365/qt-disabling-qdialogs-button

• https://stackoverflow.com/questions/41585596/remove-windowsystemmenuhint-from-qdialog-in-qt/41585718#41585718

• https://stackoverrun.com/fr/q/11444028

• https://issue.life/questions/81627

setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);

Search on GitHub:

Qt::AA_DisableWindowContextHelpButton

• https://github.com/search?o=desc&q=Qt%3A%3AAA_DisableWindowContextHelpButton&s=indexed&type=Code

~Qt::WindowContextHelpButtonHint

• https://github.com/search?o=desc&q=~Qt%3A%3AWindowContextHelpButtonHint&s=indexed&type=Code

"Qt::AA_DisableWindowContextHelpButton"

• https://github.com/search?o=desc&q=%22Qt%3A%3AAA_DisableWindowContextHelpButton%22&s=indexed&type=Code

"flags = flags & (~helpFlag);"

• https://github.com/search?o=desc&q=%22flags+%3D+flags+%26+%28~helpFlag%29%3B%22&s=indexed&type=Code

"~Qt::WindowContextHelpButtonHint)"

• https://github.com/search?o=desc&q=%22~Qt%3A%3AWindowContextHelpButtonHint%22&s=indexed&type=Code

Choices:
1/

// Don't show the context help '?' button in the window bar.
setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);

2/

Qt::WindowFlags flags = windowFlags();

// remove Help Button of window
Qt::WindowFlags helpFlag = Qt::WindowContextHelpButtonHint;
flags = flags & ( ~helpFlag );
this->setWindowFlags( flags );

3/

Qt::WindowFlags flags = windowFlags();
Qt::WindowFlags helpFlag = Qt::WindowContextHelpButtonHint;

flags = flags & (~helpFlag);
setWindowFlags(flags);

4/

// remove the ? in the titlebar
Qt::WindowFlags flags = windowFlags();
Qt::WindowFlags helpFlag = Qt::WindowContextHelpButtonHint;
flags = flags & (~helpFlag);
setWindowFlags(flags);

5/

Qt::WindowFlags flags = windowFlags();
Qt::WindowFlags helpFlag = Qt::WindowContextHelpButtonHint;
flags = flags & ( ~helpFlag );
this->setWindowFlags( flags );

6/ Example with Minimize and Maximize buttons

Qt::WindowFlags flags = windowFlags() | Qt::WindowMaximizeButtonHint | Qt::WindowMinimizeButtonHint;
Qt::WindowFlags helpFlag = Qt::WindowContextHelpButtonHint;
flags = flags & (~helpFlag);
setWindowFlags(flags);

7/ Example with Minimize and Maximize buttons

Qt::WindowFlags flags = windowFlags() | Qt::WindowMaximizeButtonHint | Qt::WindowMinimizeButtonHint;
Qt::WindowFlags helpFlag = Qt::WindowContextHelpButtonHint;
flags = flags & ( ~helpFlag );
setWindowFlags( flags );

[Neustradamus]

This issue is now solved for Qt 5.10.1 and more before Qt 6.0 with my PR: #508.

For Qt 5.0 >= 5.9.x, and Qt 5.10.0 (bug included) need:

// Don't show the context help '?' button in the window bar.
setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);