Remove unused/deprecated schmidt_add and normalize fns from libqt #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiborGY
added a commit
to TiborGY/psi4attic
that referenced
this pull request
Apr 22, 2023
TiborGY
added a commit
to TiborGY/psi4attic
that referenced
this pull request
Apr 22, 2023
TiborGY
added a commit
to TiborGY/psi4attic
that referenced
this pull request
Apr 22, 2023
JonathonMisiewicz
approved these changes
Apr 22, 2023
loriab
added
the
cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Both
normalizeandschmidt_addare now unused.schmidt_addisPSI_API, but it has been given a deprecation period of one release. The files will be submitted to the attic after this is merged.User API & Changelog headlines
PSI_APIfunctionschmidt_add(double** A, int rows, int cols, double* v)has been removed.Dev notes & details
normalizefunction and file are removedPSI_APIfunctionschmidt_addand file are removedChecklist
Status