Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove new's in SOBasis #3024

Merged
merged 2 commits into from Aug 14, 2023
Merged

Remove new's in SOBasis #3024

merged 2 commits into from Aug 14, 2023

Conversation

susilehtola
Copy link
Member

Description

A quick cleanup removing new and delete in favor of std::vector in SOBasis.

User API & Changelog headlines

  • RN 1
  • RN 2

Dev notes & details

  • Feature1
  • Feature2

Questions

  • Question1

Checklist

Status

  • Ready for review
  • Ready for merge

JonathonMisiewicz
JonathonMisiewicz approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@JonathonMisiewicz JonathonMisiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍺

loriab
loriab approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me and certainly much tidier. If there's another cause for a new commit, the comments in the header file that got disassociated with the member data/fns could be added back.

@loriab loriab added this to the Psi4 1.9 milestone Aug 14, 2023
@loriab loriab added libmints For things that are wrong with libmints (but not wavefunction). cleanup For issues where the goal is to make Psi4 a little cleaner. labels Aug 14, 2023
@loriab loriab added this pull request to the merge queue Aug 14, 2023
Merged via the queue into psi4:master with commit 81495e5 Aug 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loriab loriab loriab approved these changes

@JonathonMisiewicz JonathonMisiewicz JonathonMisiewicz approved these changes

Assignees
No one assigned
Labels
cleanup For issues where the goal is to make Psi4 a little cleaner. libmints For things that are wrong with libmints (but not wavefunction).
Projects
None yet
Milestone
Psi4 1.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@susilehtola @loriab @JonathonMisiewicz