Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix printing of dispersion gradients #3082

Merged
merged 1 commit into from Nov 21, 2023
Merged

Fix printing of dispersion gradients #3082

merged 1 commit into from Nov 21, 2023

Conversation

philipmnel
Copy link
Contributor

@philipmnel philipmnel commented Nov 17, 2023 •
edited

Description

Issue from forums: https://forum.psicode.org/t/dispersion-gradients/2979

Dev notes & details

  • Fix issue where the dispersion correction contribution to gradients is not correctly labelled when debug printing is enabled.

Checklist

Status

  • Ready for review
  • Ready for merge

loriab
loriab approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@loriab loriab added this to the Psi4 1.9 milestone Nov 18, 2023
@loriab loriab added this pull request to the merge queue Nov 21, 2023
Merged via the queue into psi4:master with commit d61029e Nov 21, 2023
5 checks passed
@philipmnel philipmnel deleted the philipmnel-patch-1 branch November 27, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jturney jturney jturney approved these changes

@loriab loriab loriab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Psi4 1.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@philipmnel @jturney @loriab