-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print final MBIS shell populations and widths #3102
base: master
Are you sure you want to change the base?
Conversation
Hi @kzinovjev great job adding this. @loriab It would be great to have these available via the qcengine interface so we could store them in QCArchive when MBIS charges are requested on a calculation, can you adviseif any other changes would be needed to be made to make this possible? |
Hi @kzinovjev just checking over this again and noticed that the populations and widths might already be printed can you check they match what you are printing? |
Hi @jthorton, currently only the atomic charges (so, the sum of populations of all the shells) and the widths of the last shell for each atom are printed. In contrast, with this patch the full result of MBIS density fitting is printed, so populations and widths of all the shells. This is helpful if one wants to split the atomic charges into core/valence shells, as in MEDFF, IPML or EMLE methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if (print_output && debug >= 1) { | ||
for (int atom = 0; atom < num_atoms; atom++) { | ||
for (int m = 0; m < mA[atom]; m++) { | ||
outfile->Printf(" FINAL ATOM %d, SHELL %d, POP %8.5f, WIDTH %8.5f\n", atom + 1, m + 1, Nai[atom][m], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be helpful to also print out the angular momentum of the shell (L)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @andyj10224, in MBIS the shells are just Slater functions, so they are spherically symmetric (L=0).
Description
For some applications it may be helpful to know the converged populations and widths of all shells in MBIS, so here goes the patch. As for the initial values, the info is only printed when debug>=1
User API & Changelog headlines
N/A
Dev notes & details
Checklist
Status