Generalize from IO to MonadUnliftIO m => m #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes the monad that
Segment
s run in fromIO
toMonadUnliftIO m => m
. This has many benefits when interacting with theconduit
library. For example, it was not possible to useresourcet
to handle file resources when outputting to files. With this change, the following code becomes valid:This is opposed to requiring before to manage the file
Handle
yourself manually and passing it down, risking closing it too early.Since redirecting to files is a large part of writing shell scripts, I believe it is worth the cost of 1) breaking the API and 2) slightly increased complexity to integrate this change.