Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
I noticed that
checkDirs
(inapp/Main.hs
) only contains thecommon
,linux
andosx
directories, but not thewindows
directory:However, both
stack
andghc
have support for Windows; even thoughtldr-hs
will compile on Windows, it won't use the Windows specific pages.This PR aims to solve that problem.
The solution
The result is changing
checkDirs
from it's previously stated definition to:and changing
getPagePath
, from:to:
Status
This solution works perfectly fine on my
Ubuntu 18.04.1
machine:(both
assoc
andcls
are in thewindows
pages directory;adduser
is merely used to show that pages from other directories still load).