Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect 2021 *_brk5 and *_brk6 policy parameter values #2655

Closed
martinholmer opened this issue Apr 5, 2022 · 2 comments
Closed

Incorrect 2021 *_brk5 and *_brk6 policy parameter values #2655

martinholmer opened this issue Apr 5, 2022 · 2 comments
Labels

Comments

@martinholmer
Copy link
Collaborator

martinholmer commented Apr 5, 2022

The II and PT _brk5 and _brk6 amounts of all the filing unit types are incorrect. It appears as if the 2021 values were incorrectly specified to be the same as the 2022 values. You can check IRS (or any other reliable source) for the correct 2021 values.

Being human, we all makes mistakes, especially when doing tedious tasks. Humans making mistakes is to be expected, which is why source code should be tested. The maintainers of Tax-Calculator need to ask themselves why their testing strategy is failing to find such mistakes.

@MattHJensen @jdebacker @donboyd5

@MaxGhenis
Copy link
Contributor

MaxGhenis commented Apr 5, 2022

It looks like the 2022 values are correct, and 2021 are incorrect. If it's helpful, @nikhilwoodruff added these to openfisca-us in https://github.com/PolicyEngine/openfisca-us/blob/master/openfisca_us/parameters/irs/income/bracket.yaml

@jdebacker
Copy link
Member

Resolved with PR #2652.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants