Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hold cancels #58

Merged
merged 7 commits into from
Jan 15, 2020
Merged

Hold cancels #58

merged 7 commits into from
Jan 15, 2020

Conversation

cdmo
Copy link
Contributor

@cdmo cdmo commented Jan 6, 2020 •
edited
Loading

@cdmo cdmo added this to the 0.1.x Pre Release milestone Jan 6, 2020
@cdmo cdmo self-assigned this Jan 6, 2020
@cdmo cdmo changed the title WIP: Hold action WIP: Hold cancels Jan 6, 2020
@cdmo cdmo force-pushed the hold-action branch 6 times, most recently from 717af54 to b63a1d3 Compare January 7, 2020 17:54
@cdmo
Copy link
Contributor Author

cdmo commented Jan 7, 2020

Will handle #61 too

@cdmo
Copy link
Contributor Author

cdmo commented Jan 7, 2020

Adding jest and eslint as well, now that there's javascript

@cdmo cdmo force-pushed the hold-action branch 2 times, most recently from 2596dca to 1382448 Compare January 10, 2020 21:02
@cdmo
Copy link
Contributor Author

cdmo commented Jan 10, 2020

There is more work left to do for holds. But I'd like to submit this as a PR and continue the remaining work in a separate branch. The reason is mainly because this branch already has a lot of weight. Will create remaining issues for tasks. That okay?

@cdmo cdmo requested a review from banukutlu January 10, 2020 21:03
@cdmo cdmo changed the title WIP: Hold cancels Hold cancels Jan 10, 2020
This was referenced Jan 10, 2020
Closed
Closed
Closed
@cdmo
Copy link
Contributor Author

cdmo commented Jan 14, 2020

I don't know why it's not generating an "Overall coverage" thing, but I am seeing all the correct files in the latest test

@cdmo
Copy link
Contributor Author

cdmo commented Jan 14, 2020

Oh and now it does, just took it a minute I guess

@cdmo
Copy link
Contributor Author

cdmo commented Jan 14, 2020

Code Climate docs. Used example 1 from multiple test suites.

@cdmo cdmo force-pushed the hold-action branch 2 times, most recently from 118354e to fbf298b Compare January 14, 2020 20:34
@banukutlu
Copy link
Contributor

Code Climate docs

Thanks, this is helpful :)

Charlie Morris added 2 commits January 14, 2020 15:49
Adds hold cancellation
b273386 
* Adds rudimentary menu
* Refines the hold model a bit more with respect to status codes especially.
* Adds symphony client http request for canceling
* Adds form to holds table for canceling
* Yarn lock update (unrelated)
* Removes unneeded travis config (unrelated)
* Adds import bootstrap line to resolve undefined variable error in webpack
* Adds selectAll module and implements on holds page
* Disables PlaceholderInExtend in scss lint
* Adds subtle change to short time format
* Adds a caption override for Twitter Bootstrap
* Removes some unused code from initial commits, fixes typos
Adds CodeClimate
fe96ce5
banukutlu
banukutlu approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@banukutlu banukutlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 👌

@banukutlu banukutlu merged commit a3df4cb into master Jan 15, 2020
@banukutlu banukutlu deleted the hold-action branch January 15, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banukutlu banukutlu banukutlu approved these changes

Assignees

@cdmo cdmo

Labels
None yet
Projects
None yet
Milestone
0.1.x Pre Release
Development

Successfully merging this pull request may close these issues.
2 participants
@cdmo @banukutlu