Store callnumber if record is 'In the Library' #465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #461
Replaced
online?
method inholdings.rb
withnot_in_the_library?
method that checks if the record'saccess_facet
includes 'In the Library'. If a record is not in the library it will not have a callnumber. On the other hand, anything (including records that are also online) that is in the library will have a callnumber. Added some tests to test a couple different variations ofaccess_facets
.