Support 'empty' prop and type 'any' #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // If empty (and empty allowed), move forward | ||
| if (context.def.empty && context.value.length === 0) { | ||
| return context.value | ||
| } |
There was a problem hiding this comment.
We're not failing in the event that empty isn't allowed, and context.value is an empty array
|
Strings and arrays were already allowed to be empty before this push -- it would be good to have a test around the failure case for each of these, to prove empty values can be blocked. |
|
@TomFrost I'll write some integration tests to cover your last comment since it will need to move into the actual type checks. |
ksafranski
added a commit
that referenced
this pull request
Mar 4, 2016
Support 'empty' prop and type 'any'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23 and Closes #22