-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addressing #39 #98
Addressing #39 #98
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 93.22% 93.14% -0.08%
==========================================
Files 16 16
Lines 487 496 +9
==========================================
+ Hits 454 462 +8
- Misses 33 34 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Add a marker at the end of the build log for datalad-debian to discover. We want `deb-build-package`'s internal `containers-run` call to come back zero and commit the log, but `deb-build-package` needs to be able to discover and report that something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me! Thx.
I left a comment pointing out a relevant helper.
Given that this PR was approved and I only did a minor review suggestion to use a helper; and the fact that the tests pass, I'll merge this. |
Add a marker at the end of the build log for datalad-debian to discover.
We want
deb-build-package
's internalcontainers-run
call to comeback zero and commit the log, but
deb-build-package
needs to be ableto discover and report that something went wrong.
In opposition to what's described under 1. in #39 (comment), we now get this (returns non-zero):
Not yet unittested