BF: Ok button overriding saved prefs after Apply clicked. #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If changes were made to audio devices in the prefs dlg, the preferences were overwritten by previous preferences when the apply button was used followed by Ok button. No other selections seem to be affected by this bug. Solution: remove redundant 'Apply' button.
dvbridges
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1832 +/- ##
==========================================
+ Coverage 46.96% 46.97% +<.01%
==========================================
Files 219 219
Lines 33483 33477 -6
Branches 5611 5611
==========================================
Hits 15725 15725
+ Misses 16197 16191 -6
Partials 1561 1561
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If changes were made to audio devices in the prefs dlg, the preferences were overwritten by previous preferences when the apply button was used followed by Ok button. No other selections seem to be affected by this bug. Solution: remove redundant 'Apply' button.