Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: In Py3, JSON calib files were not loaded into mon list #1839

Merged
merged 1 commit into from May 30, 2018

Conversation

@dvbridges
Copy link
Contributor

@dvbridges dvbridges commented May 25, 2018

No description provided.

@codecov-io
Copy link

@codecov-io codecov-io commented May 25, 2018

Codecov Report

Merging #1839 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1839      +/-   ##
==========================================
+ Coverage   46.73%   46.75%   +0.01%     
==========================================
  Files         221      221              
  Lines       33830    33832       +2     
  Branches     5674     5675       +1     
==========================================
+ Hits        15811    15818       +7     
+ Misses      16449    16447       -2     
+ Partials     1570     1567       -3
Impacted Files Coverage Δ
psychopy/monitors/calibTools.py 39.44% <100%> (+0.21%) ⬆️
psychopy/data/base.py 72.76% <0%> (+0.89%) ⬆️
psychopy/visual/textbox/fontmanager.py 69.96% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab9072...520cf2f. Read the comment docs.

@peircej peircej merged commit 83ca383 into psychopy:master May 30, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details
@dvbridges dvbridges deleted the dvbridges:monitorList branch Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants