New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add self._move.close()to MovieStim3._uload, #1917

Merged
merged 1 commit into from Jul 30, 2018

Conversation

Projects
None yet
2 participants
@tjwilli58

tjwilli58 commented Jul 29, 2018

add self._mov.close() to MovieStim3._uload, move self._unload() in MovieStim3.stop after logging code.

Calling self._mov.close() seems to prevent invalid handle error in call to
ffmpeg_reader in moviepy module.

See
https://stackoverflow.com/questions/43966523/getting-oserror-winerror-6-the-handle-is-invalid-in-videofileclip-function

add self._move.close()to MovieStim3._uload, move self._unload() in Mo…
…vieStim3.stop after logging code.

Calling self._move.close() seems to prevent invalid handle error in call to
ffmpeg_reader in moviepy module.

See
https://stackoverflow.com/questions/43966523/getting-oserror-winerror-6-the-handle-is-invalid-in-videofileclip-function

@peircej peircej merged commit d76d94e into psychopy:master Jul 30, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
LGTM analysis: Python No alert changes
Details
@peircej

This comment has been minimized.

Show comment
Hide comment
@peircej

peircej Jul 30, 2018

Member

Thanks. For future commit messages (the pull request text doen'st matter) could you try and make sure you follow the information here regarding BF, FF...
In your case the commit should have been BF: to indicate that this commit would need copying to other (release) branches as a fixed bug. Thanks.

PS I don't think the reordering aspects are probably important but well done for tracking down the _move.close() call :-)

Member

peircej commented Jul 30, 2018

Thanks. For future commit messages (the pull request text doen'st matter) could you try and make sure you follow the information here regarding BF, FF...
In your case the commit should have been BF: to indicate that this commit would need copying to other (release) branches as a fixed bug. Thanks.

PS I don't think the reordering aspects are probably important but well done for tracking down the _move.close() call :-)

@tjwilli58

This comment has been minimized.

Show comment
Hide comment
@tjwilli58

tjwilli58 Jul 30, 2018

Sorry about that. I was intending to, but after reading through the github tutorial, creating a fork, and getting to the point where I actually could make a pull request, I simply forgot. (My first PR)

tjwilli58 commented Jul 30, 2018

Sorry about that. I was intending to, but after reading through the github tutorial, creating a fork, and getting to the point where I actually could make a pull request, I simply forgot. (My first PR)

@tjwilli58 tjwilli58 deleted the tjwilli58:fix-movie3 branch Jul 31, 2018

@peircej

This comment has been minimized.

Show comment
Hide comment
@peircej

peircej Jul 31, 2018

Member

No worries. Thanks for the PR!

Member

peircej commented Jul 31, 2018

No worries. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment