add self._move.close()to MovieStim3._uload, #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vieStim3.stop after logging code. Calling self._move.close() seems to prevent invalid handle error in call to ffmpeg_reader in moviepy module. See https://stackoverflow.com/questions/43966523/getting-oserror-winerror-6-the-handle-is-invalid-in-videofileclip-function
|
Thanks. For future commit messages (the pull request text doen'st matter) could you try and make sure you follow the information here regarding BF, FF... PS I don't think the reordering aspects are probably important but well done for tracking down the |
|
Sorry about that. I was intending to, but after reading through the github tutorial, creating a fork, and getting to the point where I actually could make a pull request, I simply forgot. (My first PR) |
|
No worries. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add self._mov.close() to MovieStim3._uload, move self._unload() in MovieStim3.stop after logging code.
Calling self._mov.close() seems to prevent invalid handle error in call to
ffmpeg_reader in moviepy module.
See
https://stackoverflow.com/questions/43966523/getting-oserror-winerror-6-the-handle-is-invalid-in-videofileclip-function