Small bugfix in MovieStim.__init__

[arokem]

There was no default behavior for setting self._useShaders. Added setting it to False. Is that really the appropriate default behavior?

[peircej]

Actually Ariel, I don't think the self._useShaders ever gets used in the MovieStim code (so doesn't matter what the value is). You said before that it caused transparency to work on your machine, but are you sure? I think it doesn't ever get touched.

[arokem]

Since it inherits from _BaseVisualStim, it has a setOpacity method (which works great for me, for fading movies in and out), which includes:

if not self._useShaders

[peircej]

Right, yes, good point.

In this case, if _useShaders is ever False, then the MovieStim will try to create an opacity mask, which it shouldn't do. So, actually, we should either:
a) override setOpacity for the MovieStim and exclude the part about _useShaders and setMask()
b) set MovieStim._useShaders to be True always (irrespective of win._haveShaders)
Although b) is a bit of a hack, the shaders won't actually be used, so it doesn't matter that the gfx card may not support them.
I don't actually think it matters much which way.

[peircej]

that's weird - it converted my underscores to itals using wiki markup, but not yours?!

[arokem]

Yes. Weird. OK - I am sending another pull request for option a (which I just tested on my machine and works fine). I think it is a cleaner solution than b.

[peircej]

cool - I'll fetch that in a moment