Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: add spacebar to the valid keys #2310

Merged
merged 2 commits into from Feb 27, 2019

Conversation

Projects
None yet
5 participants
@superabe
Copy link
Contributor

superabe commented Feb 27, 2019

I found the spacebar is missing

Traceback (most recent call last):
  File "stimulus_show.py", line 40, in <module>
    event.globalKeys.add(key='space', func=pause)
  File "/usr/local/lib/python3.6/site-packages/psychopy/event.py", line 1090, in add
    raise ValueError('Unknown key specified: %s' % key)
ValueError: Unknown key specified: space

And adding the spacebar to the valid keys can fix this.

zhangdongdong

@superabe superabe changed the title BF: add spacebar to valid keys BF: add spacebar to the valid keys Feb 27, 2019

@superabe superabe marked this pull request as ready for review Feb 27, 2019

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 27, 2019

Codecov Report

Merging #2310 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2310      +/-   ##
==========================================
- Coverage   42.88%   42.87%   -0.02%     
==========================================
  Files         221      221              
  Lines       38574    38574              
  Branches     6648     6648              
==========================================
- Hits        16543    16539       -4     
- Misses      20463    20466       +3     
- Partials     1568     1569       +1
Impacted Files Coverage Δ
psychopy/event.py 60.64% <100%> (ø) ⬆️
psychopy/app/connections/news.py 46.66% <0%> (-8.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbfd927...8ae0e08. Read the comment docs.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 27, 2019

Coverage Status

Coverage decreased (-0.02%) to 46.939% when pulling 8ae0e08 on superabe:fix-spacebar-missing-error into bbfd927 on psychopy:master.

@hoechenberger
Copy link
Member

hoechenberger left a comment

Thanks! Could you remove the comment please? It’s not necessary and seems a bit out of place here :)

zhangdongdong
@superabe

This comment has been minimized.

Copy link
Contributor Author

superabe commented Feb 27, 2019

Sure! Already removed.

@hoechenberger

This comment has been minimized.

Copy link
Member

hoechenberger commented Feb 27, 2019

Thanks!

@peircej

This comment has been minimized.

Copy link
Member

peircej commented Feb 27, 2019

For future reference please use a commit message with one of BF: FF:... as listed in
https://www.psychopy.org/developers/repository.html#commit-messages

Without them we can't readily filter what should should not be included in bug-fix releases.

thanks for the contribution

@peircej peircej merged commit 2a91420 into psychopy:master Feb 27, 2019

2 checks passed

LGTM analysis: Python No new or fixed alerts
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

peircej added a commit that referenced this pull request Mar 5, 2019

BF: add spacebar to the valid keys (#2310)
* add spacebar to valid keys

* remove unnecessary comment

peircej added a commit that referenced this pull request Mar 5, 2019

BF: add spacebar to the valid keys (#2310)
* add spacebar to valid keys

* remove unnecessary comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.