New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BF: add spacebar to the valid keys #2310
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2310 +/- ##
==========================================
- Coverage 42.88% 42.87% -0.02%
==========================================
Files 221 221
Lines 38574 38574
Branches 6648 6648
==========================================
- Hits 16543 16539 -4
- Misses 20463 20466 +3
- Partials 1568 1569 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you remove the comment please? It’s not necessary and seems a bit out of place here :)
Sure! Already removed. |
Thanks! |
For future reference please use a commit message with one of BF: FF:... as listed in Without them we can't readily filter what should should not be included in bug-fix releases. thanks for the contribution |
* add spacebar to valid keys * remove unnecessary comment
* add spacebar to valid keys * remove unnecessary comment
I found the spacebar is missing
And adding the spacebar to the valid keys can fix this.