BF: sounds with variable duration falling foul of test for brief duration #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion We should test for brief duration at run time rather than compile time (if we need to tst for that at all)
Use self.params['stopVal'] not self.params['stopVal'].val in string so that for example, $var gets converted correctly to `var` in the script
3 similar comments
Codecov Report
@@ Coverage Diff @@
## 3.1 #2467 +/- ##
==========================================
+ Coverage 44.71% 44.76% +0.05%
==========================================
Files 228 228
Lines 39499 39491 -8
Branches 6817 6813 -4
==========================================
+ Hits 17663 17680 +17
+ Misses 19989 19970 -19
+ Partials 1847 1841 -6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.