BF: Call endLoopIteration when isTrials is False so loop can be broken #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The endLoopIteration was not being called when isTrials was false, meaning that the loop could not be broken using loop.finished. Adding the endLoopIteration function to loops where isTrials is false means that the a new arg `isTrials` must be passed, because `isTrials` never actually exists in the `thisTrials` arg, so can not satisfy the else if statement, and thisTrial can be both defined and undefined when isTrials is false, meaning nextEntry could be called when it should not be. Now, endLoopIteration will only call nextEntry if isTrials is true if not trying to break loop manually.
Codecov Report
@@ Coverage Diff @@
## master #2517 +/- ##
=========================================
+ Coverage 44.5% 44.5% +<.01%
=========================================
Files 232 232
Lines 40291 40289 -2
Branches 6925 6924 -1
=========================================
Hits 17931 17931
+ Misses 20462 20460 -2
Partials 1898 1898
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endLoopIteration was not being called when isTrials was false, meaning
that the loop could not be broken using loop.finished. Adding the
endLoopIteration function to loops where isTrials is false means that the
a new arg
isTrialsmust be passed, becauseisTrialsnever actuallyexists in the
thisTrialsarg, so can not satisfy the else if statement,and thisTrial can be both defined and undefined when isTrials is false,
meaning nextEntry could be called when it should not be. Now,
endLoopIteration will only call nextEntry if isTrials is true if not
trying to break loop manually.