Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS version tweak for 3.2.3 #2612

Merged
merged 4 commits into from Sep 12, 2019
Merged

JS version tweak for 3.2.3 #2612

merged 4 commits into from Sep 12, 2019

Conversation

peircej
Copy link
Member

@peircej peircej commented Sep 12, 2019

For JS we don't need a new version on each bugfix (can be applied online without release) so when users do useVersion('3.3.1') the JS lib shoudl be psychojs-3.3.js

@coveralls
Copy link

coveralls commented Sep 12, 2019

Coverage Status

Coverage increased (+0.006%) to 49.1% when pulling 8819c97 on peircej:master into 4f2475a on psychopy:master.

@codecov-io
Copy link

codecov-io commented Sep 12, 2019

Codecov Report

Merging #2612 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2612      +/-   ##
==========================================
- Coverage   44.37%   44.36%   -0.01%     
==========================================
  Files         234      234              
  Lines       41615    41618       +3     
  Branches     7198     7199       +1     
==========================================
- Hits        18466    18465       -1     
- Misses      21181    21184       +3     
- Partials     1968     1969       +1
Impacted Files Coverage Δ
psychopy/__init__.py 73.07% <100%> (ø) ⬆️
...sychopy/experiment/components/settings/__init__.py 72.08% <42.85%> (-0.36%) ⬇️
psychopy/visual/window.py 66.47% <0%> (-0.69%) ⬇️
psychopy/tools/wizard.py 73.74% <0%> (+0.43%) ⬆️
psychopy/web.py 42.94% <0%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f2475a...8819c97. Read the comment docs.

@peircej peircej merged commit f0b81fe into psychopy:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants