Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Builder failing to sync new git projects #3626

Merged
merged 1 commit into from Feb 24, 2021

Conversation

peircej
Copy link
Member

@peircej peircej commented Feb 24, 2021

The switch to use check_output meant that when there was no
existing git repo in the folder the call git branch --show-current
returns non-zero but with check_output that causes an error to be
raised. We don't want that - we want to know it happened and move on.

The switch to use check_output meant that when there was no
existing git repo in the folder the call `git branch --show-current`
returns non-zero but with check_output that causes an error to be
raised. We don't want that - we want to know it happened and move on.
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #3626 (33b3d80) into release (485d29c) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           release    #3626      +/-   ##
===========================================
+ Coverage    43.13%   43.16%   +0.03%     
===========================================
  Files          267      267              
  Lines        52629    52691      +62     
  Branches      9063     9082      +19     
===========================================
+ Hits         22700    22743      +43     
- Misses       27616    27624       +8     
- Partials      2313     2324      +11     
Impacted Files Coverage Δ
psychopy/projects/pavlovia.py 22.13% <66.66%> (+1.68%) ⬆️
psychopy/app/builder/dialogs/paramCtrls.py 58.76% <0.00%> (-0.67%) ⬇️
psychopy/app/builder/builder.py 47.14% <0.00%> (-0.25%) ⬇️
psychopy/app/builder/dialogs/__init__.py 40.96% <0.00%> (-0.07%) ⬇️
psychopy/visual/basevisual.py 67.79% <0.00%> (-0.01%) ⬇️
psychopy/visual/line.py 91.42% <0.00%> (ø)
psychopy/colors.py 56.17% <0.00%> (+0.25%) ⬆️
psychopy/visual/form.py 64.15% <0.00%> (+0.34%) ⬆️
psychopy/visual/slider.py 69.50% <0.00%> (+0.50%) ⬆️
psychopy/tools/colorspacetools.py 75.58% <0.00%> (+1.05%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 485d29c...33b3d80. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 24, 2021

Coverage Status

Coverage increased (+0.03%) to 47.025% when pulling 33b3d80 on peircej:hotfix-git-check-branch into ceb51c1 on psychopy:release.

@peircej peircej merged commit b8027ee into psychopy:release Feb 24, 2021
@peircej peircej deleted the hotfix-git-check-branch branch February 26, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants