New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Improvements to attributeSetter decorator #6396
Conversation
…get functions for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has many (working) lines changed and may be producing errors. The changes don't seem useful to users. So to the user, it feels like this PR is a net loss - more potential bugs and no benefits
Closing, This is a substantial refactor. I'm not clear that it's necessary and has a high likelihood of introducing bugs and behaviour changes that we aren't yet aware of. It certainly isn't a priority issue for users to have changed. Let's focus on what the users need fixing |
Intention being to make it easier for plugin developers to use.
setWhatever
/getWhatever
functions, reducingsetWhatever is not defined
errors coming out of Builder because xyz developer forgot to create that functionattributeSetter has no attribute xyz
because you forgot to set something in initTested the speed and it doesn't seem any slower, which makes sense as there's not really any extra overhead once the attribute is set once - the only things which take any time are setting the get/set methods (which only happens once, on class import) and generating the method sig to get default (which only happens if the value hasn't been set)