New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc small commits #854

Merged
merged 7 commits into from Mar 1, 2015

Conversation

Projects
None yet
3 participants
@jeremygray
Member

jeremygray commented Feb 27, 2015

Motivation: testing PsychoPy mouse code & experiments, maybe use in actual experiments

Current description:

  • fully backwards compatible
  • want an emulation mode that sets mouse RT as a side effect
  • very fast (< 10^-5s), effectively as fast as before; profiling revealed a 250ms delay
    for the first mention of pyglet.window.mouse.LEFT MIDDLE RIGHT
  • move import pyglet.window.mouse.LEFT etc earlier to avoid 250ms first-mention
    delay; don't want that to happen during an experiment trial
  • RF to allow for multiple buttons at once via a single integer code

Still to-do:

  • add a proper API in psychopy.hardware.emulator?
  • emulation of click coordinates x, y; they can be given here but no effect (merely logged)
ENH: start on emulating pyglet mouse events
Uses: testing PsychoPy mouse code & experiments, maybe use in actual experiments

Current description:
- fully backwards compatible
- want an emulation mode that sets mouse RT as a side effect
- very fast (< 10^-5s), effectively as fast as before; profiling revealed a 250ms delay
   for the first mention of pyglet.window.mouse.LEFT MIDDLE RIGHT
- move import pyglet.window.mouse.LEFT etc earlier to avoid 250ms first-mention
   delay; don't want that to happen during an experiment trial
- RF to allow for multiple buttons at once via a single integer code

Still to-do:
- add a proper API in psychopy.hardware.emulator?
- emulation of click coordinates x, y; they can be given here but no effect (merely logged)
@coveralls

This comment has been minimized.

coveralls commented Feb 27, 2015

Coverage Status

Coverage increased (+0.03%) to 50.93% when pulling f78a9b3 on jeremygray:master into df68d43 on psychopy:master.

jeremygray added some commits Feb 28, 2015

TEST: test_event was giving intermittent mouseMoved() failures
- mouseMoved is not tested on travis, was giving errors locally, but not reliably
- more liberal time criterion for test_keys
@coveralls

This comment has been minimized.

coveralls commented Feb 28, 2015

Coverage Status

Coverage increased (+0.03%) to 50.93% when pulling 87da3d4 on jeremygray:master into df68d43 on psychopy:master.

@coveralls

This comment has been minimized.

coveralls commented Feb 28, 2015

Coverage Status

Coverage increased (+0.01%) to 50.91% when pulling 87da3d4 on jeremygray:master into df68d43 on psychopy:master.

BF: decorate visual.Window.mouseVisible with @attributeSetter
- seems like this was intended but not implemented
- win.close() could leave mouse invisible, now set to be visible upon close()
@coveralls

This comment has been minimized.

coveralls commented Feb 28, 2015

Coverage Status

Coverage increased (+0.04%) to 50.94% when pulling 3062b80 on jeremygray:master into df68d43 on psychopy:master.

jeremygray added some commits Feb 28, 2015

BF: setPos positions have to be int
- had a type error on travis, haven't seen it on Mac
@coveralls

This comment has been minimized.

coveralls commented Feb 28, 2015

Coverage Status

Coverage increased (+0.03%) to 50.93% when pulling 8a1ba80 on jeremygray:master into df68d43 on psychopy:master.

@jeremygray jeremygray changed the title from ENH: start on emulating pyglet mouse events to misc small commits Feb 28, 2015

@coveralls

This comment has been minimized.

coveralls commented Feb 28, 2015

Coverage Status

Coverage increased (+0.03%) to 50.93% when pulling b896d23 on jeremygray:master into df68d43 on psychopy:master.

peircej added a commit that referenced this pull request Mar 1, 2015

@peircej peircej merged commit 63cd56a into psychopy:master Mar 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment