-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish manylinux2014 wheels #124
Comments
Hi Richard, thank you very much! I have no idea if it's possible to publish two different manylinux tags for the same distribution, and how well pip would cope with it. I tested the platform to build manylinux2014 and it has too old versions of libpq and libssl so I wouldn't really want to distribute them, or have users installing them by mistake because it's not well defined what pip will install. Upgrading the libraries means compiling them from source, which we do in psycopg2 but it is a major chore. Is it very bad to install a source distribution for you (i.e. |
It seems to be possible to publish multiple manylinux tags for the same distribution if I understand things correctly (see numpy as an example). I definitely understand your hesitation to publish psycopg linked against (very) old versions of libpq and libssl. I'd likely try to do the same in your situation. My suggestion would be to publish manylinux2014 wheels until CentOS 7 hits EOL in June 2024 (and generally to build/publish for all current manylinux docker images). We can certainly install |
Update - we ran into an issue building |
It's not the first time that I hear that pipenv has problems with psycopg. If there are things that we can fix happy to know. If you put together a script to generate the manylinux2014 wheels and if pip works well with them we can include them in our pipeline. You might use the psycopg2 one as a starting point. |
Sorry to disappear for a month. Been traveling and working on other things. I see that psycopg includes a far more comprehensive matrix for wheels than psycopg2. Would you rather I limit the manylinux2014 build to x86 and i686 or add it as another item in the matrix which will push the number of linux wheels from 40 up to 80. I'm testing out the image right now to make sure the build works as expected |
Hello Richard, and thank you very much, no need to apologise.
This would be better, yes: a psycopg release is already in the order of 150Mb on PyPI. Could you please let me know, in the Centos image used for the build:
Cheers! |
Looks like we'll have to build openssl (1.0.2 installed) and libpq (none installed, 5.5 available from postgres 9.2.24 in the default repositories). I'll check out the sysconfig stuff though I'm not confident about getting a real answer.
Edit: that didn't actually make any sense. Why would they have such old versions of libc. i686 is fine. |
9.2 is too old to be serviceable. It will require |
Hi, just to let you know, after knowing of pypa/manylinux#1332 I think we should bite the bullet and publish manylinux2014 wheels. I will dust off the psycopg2 build script and adapt it to psycopg 3. |
manylinux_2_24 is soon EOL and 2_28 will be incompatible with many distributions to come. See <pypa/manylinux#1332>. Close #124
manylinux_2_24 is soon EOL and 2_28 will be incompatible with many distributions to come. See <pypa/manylinux#1332>. Close #124
manylinux_2_24 is soon EOL and 2_28 will be incompatible with many distributions to come. See <pypa/manylinux#1332>. Close #124
thank you so much! I'm sorry I wasn't able to help here. I really appreciate your work on this - I know how tedious it is to wait for these long build times |
Psycopg 3.0.15 released with manylinux2014 support. Please let me know if it works well for you :) |
I'll be trying it out later today but it installed just fine. Thanks! |
Hi Daniele, thanks so much for your hard work on this! Glad to see it out of beta! I work for a company that's still on CentOS 7 (and will be for a while) which means that we can't currently install any of the wheels from PyPI because they're all manylinux_2_24 (we're on libc 2.17). Would you consider publishing manylinux2014 wheels as well?
The text was updated successfully, but these errors were encountered: