Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visited as the info is in colormap #53

Merged
merged 1 commit into from
Aug 29, 2021

Conversation

blegat
Copy link
Contributor

@blegat blegat commented Aug 28, 2021

We have the relation visited[u] == !iszero(colormap[u]) so visited does not carry any additional information

@pszufe
Copy link
Owner

pszufe commented Aug 29, 2021

again conflicts here.
coveralls also complains about coverage increase - adding a single unit test for this change would have been nice

@blegat
Copy link
Contributor Author

blegat commented Aug 29, 2021

The lines seems to be covered by the tests. The coverage decreased because the PR removed lines that were covered so the % of covered lines decreased.

@pszufe pszufe merged commit 4854c4d into pszufe:master Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants