Fix storage_test suite #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add `ctx` parameter to ConsulStorage function calls which now require it - Set cs.Prefix properly --- setting the EnvNamePrefix environment variable does not work in the tests because that is only read if the module is be instantiated by Caddy, not during the tests. This not only actually uses the correct prefix, but now the KV cleanup done in `setupConsulEnv` cleans the proper path, so you can run tests multiple times in a row without errors because random K/V entries are left - Set the logger in `setupConsulEnv` - Switch from certmagic.ErrNotExist to fs.ErrNotExist --- see caddyserver/certmagic#168
Closed
|
Fixed alongside with #32 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctxparameter to ConsulStorage function calls which now require itsetupConsulEnvcleans the proper path, so you can run tests multiple times in a row without errors because random K/V entries are leftsetupConsulEnv