Graphic glitches in Warcraft 3 1.26

[askorbinovaya-kislota]

bisected the issue to this commit: a5a7d93

glitches look like this:

and that's how the game menu should look like:

BOX64_DYNAREC=0

simply disabling bigblock (i thought that commit referenced something about it) partially fixes the glitches, but cripples the menu even further:

BOX64_DYNAREC_BIGBLOCK=0

and with the safest dynarec options, the menu is almost fine, with a different glitch affecting the water (x87double fixed the menu):

BOX64_DYNAREC_BIGBLOCK=0 BOX64_DYNAREC_SAFEFLAGS=2 BOX64_DYNAREC_STRONGMEM=2 BOX64_DYNAREC_FASTROUND=0 BOX64_DYNAREC_FASTNAN=0 BOX64_DYNAREC_X87DOUBLE=1

none of those issues appeared on bc770d9 (a5a7d93 - 1). i've checked the issues, and it seems that no one reported exactly those glitches, but a comment at #1364 states that many games are broken on a version after march 11; the commit after which the issue happened was made on march 10, so i think they had exactly the same problem

i'm testing on android and my cpu is snapdragon 750G

[ptitSeb]

That commit? This is really stronge. I reproduce the inssue on my side, and confirm your result. I'll work on that to see what's wrong (but it maign take time as I'm not home and will have little time this week for box64 dev.)

[ptitSeb]

I pushed something, it should be better now, if you can update and test.

[askorbinovaya-kislota]

no glitches on latest commit, works fine now

[BloodANGELdb]

I pushed something, it should be better now, if you can update and test.

I confirm that there are no more graphical bugs. But there is one significant mistake left? on versions from the beginning of the month everything worked perfectly, the wine prefix loaded in a second, Now if you enable "WINEESYNC=1, WINEESYNC_TERMUX=1" the prefix will load in 30-60 seconds.

Another problem is that the GPU caps viewer refuses to show tests, it simply freezes.

[airidosas252]

3384640

This commit actually causes Wine to start up very slowly. It also causes two winedevice.exe instances to appear. After reverting this - everything goes back to normal.

It also caused Mass Effect Andromeda to hang while trying to launch it.

[askorbinovaya-kislota]

i also encountered freezes (in warcraft 3) on new version, but i thought it was wine issue...

After reverting this - everything goes back to normal.

i'll try reverting to see if freezes go away

[askorbinovaya-kislota]

i'll try reverting to see if freezes go away

can confirm, no freezes if i revert that commit

[ptitSeb]

This commit is important. I'll try to check later why it cause some regressions.