dynablock: do not access value when foreach on marks #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing the value of a kh_set (which has no values set) is an undefined behavior, which may make monsters to appear. Add a kh_foreach_key macro that do not touch values at all, and use it when ennuerating marks in dynablock, to prevent SIGSEGV of accessing non-existent values. Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
|
Nice one! (still miss the test of db->parent->blocks). |
|
oh sorry, I messed code in #171 into this PR. |
|
That's fine, If you can now just do a small PR with the test (or I'll do it later). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing the value of a kh_set (which has no values set) is an
undefined behavior, which may make monsters to appear.
Add a kh_foreach_key macro that do not touch values at all, and use it
when ennuerating marks in dynablock, to prevent SIGSEGV of accessing
non-existent values.
Signed-off-by: Icenowy Zheng icenowy@aosc.io