Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where's HTML highlight? #1

Open
Grawl opened this issue Oct 24, 2011 · 5 comments
Open

Where's HTML highlight? #1

Grawl opened this issue Oct 24, 2011 · 5 comments

Comments

@Grawl
Copy link

Grawl commented Oct 24, 2011

It highlights smarty code, but it forget to highlight basic HTML around.

@ptrm
Copy link
Owner

ptrm commented Oct 24, 2011

Yes, I waited for a stable version to start working on it, though the
solution has been available here for some time:
http://wiki.macrabbit.com/forums/viewreply/5448/.

The backward-compatible fix would be just adding the new lines and
leaving the old ones instead of replacing them I guess.

2011/10/24 Grawl
reply@reply.github.com:

It highlights smarty code, but it forget to highlight basic HTML around.

Reply to this email directly or view it on GitHub:
#1

@Grawl
Copy link
Author

Grawl commented Oct 24, 2011

I'm replaced text.html.basic to language-root.html all times in Smarty.xml and it works fine. Look for it in My fork of this Sugar.

@micha149
Copy link

micha149 commented Nov 3, 2011

Whats up with that issue?! The changes does not seem to be in this repo. @Grawl you have not created a pull-request?

@Grawl
Copy link
Author

Grawl commented Nov 3, 2011

sorry, @micha149, I'm forget to do this. now I was send it. try it.

@micha149
Copy link

micha149 commented Nov 3, 2011

No problem. I will use your fork until @ptm merged your commits.

2011/11/3 Grawl <
reply@reply.github.com>

sorry, @micha149, I'm forget to do this. now I was send it. try it.

Reply to this email directly or view it on GitHub:
#1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants