Skip to content

Commit

Permalink
fix users_df py-accengage for better memory usage
Browse files Browse the repository at this point in the history
  • Loading branch information
pualien committed Feb 4, 2019
1 parent d32b61f commit 983d3ec
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
.idea
.venv
.venv
tests
12 changes: 6 additions & 6 deletions accengage/accengage.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def set_headers(self):
}
return self.headers

def get_output_in_df(self, result, headers):
def get_output_in_list(self, result, headers):
"""
:param result: response.text from api call
Expand All @@ -105,14 +105,14 @@ def get_output_in_df(self, result, headers):
"""
data = BufferIO(result.encode())
if len(result) == 0:
return pd.DataFrame()
df = pd.read_csv(data, sep=";", header=0, encoding='utf-8', error_bad_lines=False)
return []
data_list = pd.read_csv(data, sep=";", header=0, encoding='utf-8', error_bad_lines=False).to_dict('records')
if headers.get('Link'):
response = requests.request("GET", headers['Link'].replace('<', '').replace('>; rel="next"', ''), headers=self.set_headers(), params={})
df = df.append(self.get_output_in_df(response.text, response.headers))
data_list += self.get_output_in_list(response.text, response.headers)
else:
pass
return df
return data_list

def get_users_df(self, partner_id, last_open=None):
return self.get_output_in_df(*self.get_users(partner_id=partner_id, last_open=last_open))
return pd.DataFrame(self.get_output_in_list(*self.get_users(partner_id=partner_id, last_open=last_open)))
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def reqs(*f):


setup(name='accengage',
version='0.1.3',
version='0.1.4',
url='https://github.com/pualien/py-accengage',
license='MIT',
author='Matteo Senardi',
Expand Down

0 comments on commit 983d3ec

Please sign in to comment.