Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle custom collections #96

Merged
merged 2 commits into from
May 13, 2024

Conversation

taitruong
Copy link
Collaborator

@taitruong taitruong commented May 7, 2024

#84 - use UniversalCollectionInfoResponse for handling custom collections

This is a very small change, but with huge impact: instead of using cw721::ContractInfoResponse, now ics721 defines its own UniversalCollectionInfoResponse.

Please note that cw721::ContractInfoResponse used cw_serde - so response needs to EXACTLY match struct. In case of custom collection it may hold addtional props - hence cw_serde thows an deny_unknown_fields error.

UniversalCollectionInfoResponse on the other hand just expects response to hold name and symbol for deserialization - all other props are ignored.

@humanalgorithm
Copy link
Contributor

Sounds like you are just putting this for a type of flexible field no? If so, then approve.

@jhernandezb jhernandezb merged commit 4aab9d2 into public-awesome:main May 13, 2024
1 check passed
@taitruong taitruong deleted the custom_collections branch June 10, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants