feat(x/globalfee): Ante handler fee decorator #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature/globalfee #775 +/- ##
=====================================================
+ Coverage 9.81% 10.01% +0.19%
=====================================================
Files 97 97
Lines 13880 14040 +160
=====================================================
+ Hits 1363 1406 +43
- Misses 12441 12557 +116
- Partials 76 77 +1
☔ View full report in Codecov by Sentry. |
spoo-bar
changed the title
jhernandezb
force-pushed
the
ante-handler-globalfee
branch
from
0d27d30
to
44968fc
Compare
jhernandezb
reviewed
Apr 24, 2023
Comment on lines
+49
to
+52
| // Only check for minimum fees and global fee if the execution mode is CheckTx | ||
| if !ctx.IsCheckTx() || simulate { | ||
| return next(ctx, tx, simulate) | ||
| } |
There was a problem hiding this comment.
With this validators can still propose 0fee txs right ?
There was a problem hiding this comment.
yes, in case when the validator has configured minimum-gas-prices = "0ustars"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ante handler to ensure enough fees have been set.
The fee calculation is based on gaia x/globalfee implementation
https://github.com/cosmos/gaia/blob/6fe097e3280baa360a28b59a29b8cca964a5ae97/x/globalfee/ante/fee.go
No tests. In separate PR 👉🏻 #786