Toast Service: Convert Toast to internal functional component and allow render function instead of description string #5477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt and allow render function instead of description string
…-description-in-toasterservice * 'develop' of github.com:public-ui/kolibri: (22 commits) chore: update deps fix: this commit makes the label optional for label Remove stray bracket... Fix tests Update snapshots Add missing text decoration zoll-v3: Adjust pagination zoll-v2: Adjust pagination mapz: Adjust pagination mapz: Add css tags ITZBund: Adjust pagination ITZBund: Add css tags ECL EU: Adjust pagination ECL EC: Add css tags ECL: Add css tags Pagination: Adjust bzst theme bzst: Add css tags Pagination: Adjust default theme Pagination: Adjust default and BMF styles Add classnames to button component ...
sdvg
changed the title
deleonio
requested changes
Oct 25, 2023
| onClose: () => void; | ||
| key: string; | ||
| }; | ||
| export const ToastFC = ({ toastState, onClose, key }: Props) => { |
There was a problem hiding this comment.
Empfehlung: InternalToast - Das Kol wird uns von der WebComponent-Spezifikation vorgegeben. Internal-wäre für alle glasklar, wenn Sie so was importieren, dass das keine gute Idee wäre.
…442-help-description-in-toasterservice
deleonio
approved these changes
Oct 25, 2023
| description: `Toasty`, | ||
| render: (element: HTMLElement, { close }) => { | ||
| getRoot(element).render( | ||
| <> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.