-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toast Service: Convert Toast to internal functional component and allow render function instead of description string #5477
Merged
Merged
Changes from 5 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e5da833
Toast Service: Convert Toast component to internal functional compone…
sdvg bde9937
Merge branch 'develop' of github.com:public-ui/kolibri into 5442-help…
sdvg 6eb5f25
Add missing theme changes
sdvg a655a9c
Remove unused exports
sdvg f8a7726
Remove more unused code
sdvg 386d1ac
Fix bzst toast theme
sdvg b709ce3
Add readme changes
sdvg c4d33ec
Update desy themes
sdvg bcf6b10
Replace remaining KOL-TOAST usages
sdvg 6aa0d99
Merge branch 'develop' of https://github.com/public-ui/kolibri into 5…
deleonio 3c07a09
Fix typo
sdvg 69062c6
Rename component
sdvg 20e092b
Remove KolToast from designer entirely
sdvg 52346cb
Update snapshots
sdvg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
packages/components/src/components/toast-container/ToastFC.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import { h } from '@stencil/core'; | ||
import { ToastState } from './types'; | ||
|
||
type Props = { | ||
toastState: ToastState; | ||
onClose: () => void; | ||
key: string; | ||
}; | ||
export const ToastFC = ({ toastState, onClose, key }: Props) => { | ||
const handleRef = (element?: HTMLDivElement) => { | ||
if (typeof toastState.toast.render === 'function' && element) { | ||
toastState.toast.render(element, { close: () => onClose() }); | ||
} | ||
}; | ||
|
||
return ( | ||
<div class={`toast ${toastState.status}`} key={key}> | ||
<kol-alert | ||
class="alert" | ||
_alert={true} | ||
_label={toastState.toast.label} | ||
_level={0} | ||
_hasCloser={true} | ||
_type={toastState.toast.type} | ||
_variant="card" | ||
_on={{ onClose }} | ||
> | ||
<div ref={handleRef}>{typeof toastState.toast.description === 'string' ? toastState.toast.description : null}</div> | ||
</kol-alert> | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...mponents/src/components/toast/toaster.tsx → ...rc/components/toast-container/toaster.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Empfehlung:
InternalToast
- DasKol
wird uns von der WebComponent-Spezifikation vorgegeben.Internal
-wäre für alle glasklar, wenn Sie so was importieren, dass das keine gute Idee wäre.