Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lang attribute to the html element #1133

Closed
5 tasks
leilayesufu opened this issue Oct 12, 2022 · 8 comments · Fixed by #1143
Closed
5 tasks

Add lang attribute to the html element #1133

leilayesufu opened this issue Oct 12, 2022 · 8 comments · Fixed by #1143

Comments

@leilayesufu
Copy link
Contributor

leilayesufu commented Oct 12, 2022

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from underrepresented groups in free and open-source software!

We know that the process of creating a pull request is one of the biggest barriers for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Claim the issue by commenting. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
💡 Learn how to claim 🙋

Claiming an issue

Unless the issue is marked as reserved for someone, you can just say "I'd like to try this!" and then you've claimed it - no need to wait for someone to assign it to you. Just be sure you link your pull request (PR) to this issue so we can see where your solution is.

And open one early if possible - even before you've completed it with additional commits - and others can help you figure out any issues you may face.

  • 📝 Update the file index.html in the Leaflet.DistortableImage repository (press the little pen Icon) and edit the line as shown below.
-2 <html>
+2 <html lang="en">
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@welcome
Copy link

welcome bot commented Oct 12, 2022

Thanks for opening your first issue here! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
You can make a gif too!
Do join our Gitter channel for some brainstorming discussions.

@leilayesufu
Copy link
Contributor Author

@TildaDares here’s the issue

@TildaDares
Copy link
Member

Hi @leilayesufu, can you add the line where the change will be made? Thanks!

@TildaDares
Copy link
Member

Reserved for @Straw4yu for 24 hours!

@TildaDares
Copy link
Member

@leilayesufu Do you mind informing @Straw4yu that an issue is reserved for them in publiclab/plots2#11105?

Thank you!

@Straw4yu
Copy link
Contributor

@TildaDares I will work on the issue.

@leilayesufu
Copy link
Contributor Author

@TildaDares the line number has been added, thank you

Straw4yu added a commit to Straw4yu/Leaflet.DistortableImage that referenced this issue Oct 13, 2022
Straw4yu added a commit to Straw4yu/Leaflet.DistortableImage that referenced this issue Oct 13, 2022
@leilayesufu
Copy link
Contributor Author

Oh, you already did that
Thank youu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment