Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 馃幐 display collection's images in sidebar #1028

Merged
merged 3 commits into from Sep 20, 2022
Merged

feat: 馃幐 display collection's images in sidebar #1028

merged 3 commits into from Sep 20, 2022

Conversation

PeculiarE
Copy link
Collaborator

@PeculiarE PeculiarE commented Sep 20, 2022 •
edited

Fixes #1013

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

@gitpod-io
Copy link

gitpod-io bot commented Sep 20, 2022

@PeculiarE
Copy link
Collaborator Author

Demo 1: Different responses to different inputs

sidebar-images-demo-1.mp4

@PeculiarE
Copy link
Collaborator Author

PeculiarE commented Sep 20, 2022 •
edited

Demo 2: More IA URLs

sidebar-images-demo-2.mp4

@PeculiarE
Copy link
Collaborator Author

Demo 3: No image in the collection

sidebar-images-demo-3.mp4

jywarren
jywarren approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work Peculiar!!! Thank you!!

@jywarren jywarren merged commit ecb6fe6 into publiclab:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch and display all the collection's images in the sidebar
2 participants
@PeculiarE @jywarren