fix scale/rotate/rotateScale distortions + tests

[sashadev-sky]

Testing for #341, testing scale and exposing scaleBy API
Fixes #352

• Image distorted in Scale mode #301
• images distort while scaling #85

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updates
• @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

====================
changes

• below moved to L.DistortableImageOverlay:

  • scaleBy
  • rotateBy
  • _revert: remove distortions using project, remaining bug is img shifts position a little on the map. holding off to try to fix completely in smaller PR bc will involve changes to corner initialization.

• Modes fixed:

  • scale: implement edgeminwidth, add tests, expose API
  • rotate: remove distortions using project
  • rotateScale: remove distortions using project, implement edgeminwidth

• other API:

• setCorner and setCorners exposed.

  • calls to overlay._reset, overlay.fire('update'), and overlay.editing._updateToolbarPos have all been put inside these methods for consistency - we no longer need to make these calls for each separate distortion.
    ====================

[sashadev-sky]

building on #341, I am pretty sure this PR eradicates all distortions (scale, rotate, and rotateScale). I originally opened it to expose a scale API and add tests, but ending up fixing all the modes.
@rexagod @jywarren

[rexagod]

LGTM! 👍

[sashadev-sky]

@rexagod I will bump to 0.7.0 and merge!

[jywarren]

wow, awesome!!

…

On Mon, Aug 12, 2019 at 9:14 PM Sasha Boginsky ***@***.***> wrote: Merged #380 <#380> into main. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#380?email_source=notifications&email_token=AAAF6J4OKJ2SBWGBA6Q6643QEIDEZA5CNFSM4IK5ARQ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTANQYXY#event-2551909471>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J2D2XLZU6D5MPSEW7LQEIDEZANCNFSM4IK5ARQQ> .