Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling restricted after image upload using browse option #445

Closed
shreyaa-s-zz opened this issue Apr 2, 2020 · 12 comments
Closed

Scrolling restricted after image upload using browse option #445

shreyaa-s-zz opened this issue Apr 2, 2020 · 12 comments

Comments

@shreyaa-s-zz
Copy link
Collaborator

Please describe the problem (or idea)

The code breaks if the user uses browse to enter images but works fine for drag and drop.

What happened just before the problem occurred?
When an image is entered using browse the code breaks but not with drag and drop.
The scrolling gets restricted. Despite the attempts to scroll up or down, the pointer and focus move back to the image entered.
Once this happens the issue persists with scrolling even after the image is deleted.

Please show us where to look

https://publiclab.org/post

A video representation of the same:
https://drive.google.com/file/d/1JehUreFvpVAMYR03kFTfNtzoOxwKa9ig/view?usp=sharing


Thank you!

@NitinBhasneria
Copy link
Collaborator

Please upload a GIF of the issue @Shreyaa-s.
Thanks

@shreyaa-s-zz
Copy link
Collaborator Author

@NitinBhasneria I tried but it always ends up exceeding the size limit and I have yet to find any efficient gif compressor.

@NitinBhasneria
Copy link
Collaborator

NitinBhasneria commented Apr 2, 2020

editor image
editor5
@Shreyaa-s does this describes your problem?

@NitinBhasneria
Copy link
Collaborator

Also, I want you to know that the scrolling is genuinely off. Thanks

@shreyaa-s-zz
Copy link
Collaborator Author

simplescreenrecorder-2020-04-02_23 30 56
@NitinBhasneria this is what I'm talking about. I can't scroll up or down once entering an image using browse but I can with drag and drop. I'm not sure if it's localized or a genuine bug. It would be great if you could try to reproduce it and confirm. Thanks for your input it's highly appreciated.

@shreyaa-s-zz
Copy link
Collaborator Author

Also the scrolling problem persists even after removing the image.

@NitinBhasneria
Copy link
Collaborator

Ok, I checked the error. Actually, you are checking on publiclab.org/posts, but the updated version of the editor is on PublicLab.Editor please check from there. This error is removed already thanks.
In case you need any help, feel free to ask. thanks.

@shreyaa-s-zz
Copy link
Collaborator Author

@NitinBhasneria I checked but the problem persits. If you can't reproduce it then the bug might be localized. Waiting on further confirmation. Thanks!

@NitinBhasneria
Copy link
Collaborator

Ok, @Shreyaa-s I cant see the scrolling resistance after image uploading. Scrolling is restricted when we click on image attachment and insert box appears. This needs to be fixed.Thanks

@shreyaa-s-zz
Copy link
Collaborator Author

I don't think that's a bug. With a pop up in the forground there need not be scrolling in the background.

@shreyaa-s-zz
Copy link
Collaborator Author

@NitinBhasneria since you can't reproduce the error, it might be localized. Closing this issue.

@jywarren
Copy link
Member

jywarren commented Apr 7, 2020

Thanks for digging into this folks! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants