Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes overlapping of map #392

Merged
merged 3 commits into from Mar 24, 2020
Merged

fixes overlapping of map #392

merged 3 commits into from Mar 24, 2020

Conversation

keshav234156
Copy link
Member

Fixes #367

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@welcome
Copy link

welcome bot commented Jan 28, 2020

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Please make sure you've bumped up the version number in the repository's package.json file and that you've incorporated your changes in the /dist/ sub-directory.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@keshav234156
Copy link
Member Author

Before changes

Screenshot from 2020-01-29 01-38-47

After Changes

Screenshot from 2020-01-29 01-38-40

@keshav234156
Copy link
Member Author

@jywarren Don't you think we should have external CSS instead of inline CSS?

@jywarren
Copy link
Member

Great! Thanks!

@keshav234156
Copy link
Member Author

@VladimirMikulic Please review.

Copy link
Contributor

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

examples/index.html Outdated Show resolved Hide resolved
@keshav234156
Copy link
Member Author

@emilyashley @jywarren Please give your final review and merge the changes!

@keshav234156
Copy link
Member Author

@jywarren Can you please merge the changes

@jywarren jywarren merged commit baf51ac into publiclab:master Mar 24, 2020
@jywarren
Copy link
Member

Great!!! Awesome, thank you so much!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map covers Publish button
3 participants