Refine Title Module UI - fixes issue #762 #763
Conversation
|
I'm sorry I think there's a mistake, it was meant to be just 2 commits and not 10. I created a new branch and made just 2 commits to cover all the changes for this issue but I don't know how it pushed the older commits from the older branches that have been merged already. |
|
@NARUDESIGNS I use this gist https://gist.github.com/jordanbtucker/17b6c3c7cdaca12327d0 when I have unwanted commits in my PR. |
|
@TildaDares thank you, I'd try that. |
|
Just make the branch you’re working on is updated with recent changes. |
Alright thanks, I think that's the problem. |
|
@NARUDESIGNS Doing a rebase is safe but if you’re worried you can go ahead and open a new one |
I was evaluating this. The last 2 commits are the only commits I intended for this PR. If I do |
|
|
Hi @TildaDares so I'm trying this out (first time using rebase anyway). From line 2 in the guide you shared, I did I get this error Am I doing it wrong? am I supposed to just do ? |
|
@NARUDESIGNS I think it’s supposed to be the name of your branch. My bad! |
I still get the error when I put my branch name. Should I use upstream or origin? |
|
@NARUDESIGNS I just ran the same command on my local repo and it worked
|
|
@TildaDares what branch were you on when you did this? |
|
@NARUDESIGNS I was on a branch I just created |
Same here, I wonder why I'm getting that error. You also forked the PublicLab.editor repo which is where you are creating these branches and making these changes right? |
|
@NARUDESIGNS Yes |
|
@NARUDESIGNS This article might help https://luisdalmolin.dev/blog/branched-off-the-wrong-branch-in-git/ |
|
Thanks, let me check it out. |
NARUDESIGNS
force-pushed
the
refine-ple-title-module-UI
branch
from
47e526f
to
012ae2e
Compare
|
|
|
It worked!!! 🥳 |
|
@NARUDESIGNS I’m glad that article helped you out. I don’t really have special tricks I use for finding resources, I just search google. Just make sure the search text is descriptive. For example, when I was searching for a resource to help you out, I just entered |
|
Thank you, I've learnt a lot from our conversation and this issue as well. Also I wanted to ask, after a PR has been merged, it is safe to delete the branch locally right? |
|
@NARUDESIGNS Yes it’s safe to delete the branch after it has been merged. |
|
@NARUDESIGNS Can you add a link to the issue this PR is resolving? |
|
Great! |
Here it is #762 |
|
@NARUDESIGNS Can you add before and after pics of the UI change? |
|
It doesn’t have to be now. You can do it later. |
|
Here
|
|
I’ll send a review in the morning. Thanks! |
Thank you very much! @TildaDares |
|
@NARUDESIGNS Can you help me understand why you think this change should be made to the page? |
|
Good morning @TildaDares I made some explanations about the changes in my proposal. |
|
Hi @NARUDESIGNS, your proposal has a lot of information in it so it's a lot easier for everyone if you can just give a short description of the issue (with images if need be). Thanks Paul! |
|
So I've gone through your proposal for this issue and this is what I think I think one of the reasons why numbers were chosen for this page was to give a kind of step-by-step instruction to the user on how to create a post. The first thing they notice on the page are the numbers which serve as a visual guide. The text underneath each number already gives enough description to the input elements without drawing attention away from it. The text you added draws too much attention away from the important elements. If we're going to add text, it needs to be at the background because this page is more about action than content. I like where this idea is coming from but I don’t think it would work on this page. I'm not a UI/UX expert so maybe @jywarren could chime in on this. |
|
Thank you for your opinion and review. Myself, I'm not a UI/UX designer as well but here are my own opinions.
Also, the numbers seem like this is what you need to do first and this is what you need to do next when ideally I could just input my title in step1, skip all the way and add my content in step4 and I'd be able to publish. This was why I thought it was important to be descriptive in the header instead. |
|
For the alignments and centring of elements, have a look at these screenshots and the tips on mobile view
These are steps 2 and 4. You can see the tips tightly packed onto the left on step 2 and then step 4 weirdly describing what it does or what it is meant to do. |
|
Hi all! I appreciate your thoughtfulness on this! So i think first it's really helpful to state the goals as discretely as possible - i see a few here:
I also recognize what @TildaDares is saying about the big Add Title text - it seems too big and takes a lot of page space, and it's also redundant with the "placeholder" text within the input itself (the greyed out text that disappears as you begin to type) I think we could approach this first by doing some more mockups, rather than jumping into code too quickly, so we come to agreement about how things should look even before starting to code. But once we like what we see, the PR implementation could be done in several PRs - like one for the titles, one for the horizontal squashing, etc. We might also benefit from looking at some other editors and how they render in small screens. What about Gmail's Android app for composing an email? Or Twitter's editor? Other examples, maybe like WordPress? What do we like? This is changing a really key page for the community so any major changes we may want to get buy-in from community reps, as well. But don't be overwhelmed - this should be a fun process! That said, this does seem to be embarking on a pretty large set of design issues. Are we ready for this so early in the project, and are we otherwise on track with the testing issues so far? Given that the above set of design changes may take some time to work on thoroughly in a collaborative and transparent way, maybe it's really good to start early, so by the time other issues are resolved, we've had plenty of time to think about and discuss these design changes. Anyways, i hope this is helpful! Great start here and please don't hesitate to ask more questions! |
|
Thank you very much @jywarren truly we shouldn't jump into code just yet. So I'm going to have to come up with some mock designs maybe with Figma or Adobe XD to show some UI changes, then we can agree on what works and what doesn't. |
|
That sounds great!!
…On Sun, Dec 19, 2021, 3:42 PM Paul Ibeabuchi C. ***@***.***> wrote:
Thank you very much @jywarren <https://github.com/jywarren> truly we
shouldn't jump into code just yet. So I'm going to have to come up with
some mock designs maybe with Figma or Adobe XD to show some UI changes,
then we can agree on what works and what doesn't.
—
Reply to this email directly, view it on GitHub
<#763 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J63KXDMFF7PAR4DDYTURY7T7ANCNFSM5J3RY77Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt jasminefixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!