Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted formatter jasmine file to jest test file fixes #774 #775

Merged
merged 5 commits into from Jan 11, 2022

Conversation

NARUDESIGNS
Copy link
Collaborator

@jywarren I think this one passes just fine.
Please review, thanks!

@gitpod-io
Copy link

gitpod-io bot commented Jan 3, 2022

@jywarren
Copy link
Member

jywarren commented Jan 4, 2022

Would you like to remove the corresponding test from Jasmine in the same PR?

@NARUDESIGNS
Copy link
Collaborator Author

Would you like to remove the corresponding test from Jasmine in the same PR?

Alright.

@NARUDESIGNS NARUDESIGNS changed the title Created formatter jest test file fixes #774 Converted formatter jasmine file to jest test file fixes #774 Jan 4, 2022
@NARUDESIGNS
Copy link
Collaborator Author

NARUDESIGNS commented Jan 4, 2022

@jywarren I need your help please, I'm unable to push after deleting the formatter jasmine file.
I'm not sure if this is the right thing to do:

Screenshot 2022-01-04 at 21 56 02

Or do I do git push -u origin main ?
cc @TildaDares

@NARUDESIGNS
Copy link
Collaborator Author

Oh, I've been able to delete the formatter_spec.js file and now pushed changes. Please review again @jywarren

@jywarren
Copy link
Member

I think the command would be

git push origin formatter-jest-test-conversion

to push to your own remote fork and the formatter-jest-test-conversion branch. If you did main it would try to push to your remote main branch. That'd be recoverable but you generally want your main branch to match the publiclab main branch, so you can do things like rebase on top of it. It's like saving a copy of the latest publiclab changes so you can do all your work in relation to it. Make sense?

@jywarren jywarren merged commit 6c16a21 into publiclab:main Jan 11, 2022
@jywarren
Copy link
Member

Looks super! We can start deleting all the test files we've migrated now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants