Clean up jasmine files #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…liclab/PublicLab.Editor into clean-up-jasmine-files Pulled jasmine cleanup changes from `Gruntfile.js`
…publiclab/PublicLab.Editor into clean-up-jasmine-files Pulled jasmine cleanup changes from `test.yml`
…iclab/PublicLab.Editor into clean-up-jasmine-files Pulled changes for readme file where testing section was modified
|
|
jywarren
reviewed
Feb 4, 2022
| @@ -1,33 +1,6 @@ | |||
| name: tests | |||
| on: [pull_request] | |||
| jobs: | |||
| base-tests: | |||
There was a problem hiding this comment.
I guess this will stop after we merge huh? Odd that it shows in this PR
There was a problem hiding this comment.
I think so too.
jywarren
approved these changes
Feb 4, 2022
|
Perfect!!! Thanks Paul!! |
This was referenced Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @jywarren
I've merged all the PRs for Jasmine-related changes into this. Please have a look and let me know if we're good to go.
Thank you!