Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comments to PR_TEMPLATE #1355

Closed
pythongiant opened this issue Dec 12, 2019 · 7 comments · Fixed by #2068
Closed

Add comments to PR_TEMPLATE #1355

pythongiant opened this issue Dec 12, 2019 · 7 comments · Fixed by #2068
Labels
fto-candidate

Comments

@pythongiant
Copy link

pythongiant commented Dec 12, 2019 •
edited

Please describe the problem (or idea)

The PR_TEMPLATE Currently has details that could be commented. for example

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

This could be commented. Here's how you add comments in markdown.
@welcome
Copy link

welcome bot commented Dec 12, 2019

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

@keshav234156
Copy link
Member

@pythongiant why we need to comment this?

@harshkhandeparkar
Copy link
Member

So that they don't appear in the PR body. They are just instructions for the writer, not the reader.

@YogeshSharma01
Copy link

@pythongiant can I work on this?

@willow19 willow19 mentioned this issue Apr 22, 2021
Open
7 tasks
@KarishmaVanwari
Copy link

@publiclab/is-reviewers Can I take up this issue?

@harshkhandeparkar
Copy link
Member

@publiclab/is-reviewers Can I take up this issue?

Go ahead!

KarishmaVanwari added a commit to KarishmaVanwari/image-sequencer that referenced this issue Feb 12, 2022
@KarishmaVanwari
Fixes publiclab#1355: Added comments to PR_Template
f85c00c
@KarishmaVanwari KarishmaVanwari mentioned this issue Feb 12, 2022
Merged
6 tasks
@KarishmaVanwari
Copy link

I've created a PR #2068 . Please do have a look @harshkhandeparkar.

jywarren added a commit that referenced this issue Feb 17, 2022
@KarishmaVanwari @jywarren
Fixes #1355: Added comments to PR_Template (#2068)
2585ab3 
* Fixes #1355: Added comments to PR_Template

* commented one more line

* Corrected comment

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fto-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1355: Added comments to PR_Template KarishmaVanwari/image-sequencer
5 participants
@pythongiant @harshkhandeparkar @keshav234156 @YogeshSharma01 @KarishmaVanwari