Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some modules do not work in NodeJS #1378

Closed
2 tasks
harshkhandeparkar opened this issue Dec 19, 2019 · 9 comments · Fixed by #1589
Closed
2 tasks

Some modules do not work in NodeJS #1378

harshkhandeparkar opened this issue Dec 19, 2019 · 9 comments · Fixed by #1589

Comments

@harshkhandeparkar
Copy link
Member

Please describe the problem (or idea)

This is a sub-issue of #1375

The following modules require WebGL but do not use Puppeteer to work in node:

  • Text Overlay
  • Blob Analysis

Please show us where to look

https://beta.sequencer.publiclab.org

What's your PublicLab.org username?

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@rishabhshuklax
Copy link
Member

Can I claim this issue?

@harshkhandeparkar
Copy link
Member Author

Yeah sure.

@rishabhshuklax
Copy link
Member

@harshkhandeparkar I was able to make text overlay work in node by using canvas, Should I try to make it work using pupeteer instead?

@harshkhandeparkar
Copy link
Member Author

No! It's awesome! Does it work with GIFs btw? (It doesn't matter if it doesn't work. We'll fix that separately)

@rishabhshuklax
Copy link
Member

text
I am getting this as output

@rishabhshuklax
Copy link
Member

Should I open a PR for this?

@harshkhandeparkar
Copy link
Member Author

Is it text overlay? There is an issue for GIF text overlay already.

@rishabhshuklax
Copy link
Member

Is it text overlay? There is an issue for GIF text overlay already.

Yes its text overlay

@rishabhshuklax
Copy link
Member

There is an issue for GIF text overlay already.

I'll look into it, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants