Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blob analysis to work in node #1589

Merged
merged 6 commits into from
Jan 25, 2022
Merged

Conversation

rishabhshuklax
Copy link
Member

@rishabhshuklax rishabhshuklax commented Jan 28, 2020

Fixes #1378

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@rishabhshuklax
Copy link
Member Author

rishabhshuklax commented Jan 28, 2020

This works fine in Node now but for that we need to merge #1564, because it is generating wrong output in node because the way currently pixelmanipulation.js is written.

I tested this solution in that branch and it was generating correct output for the image!

@jywarren please review this!

@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #1589 (495f250) into main (853e719) will decrease coverage by 1.38%.
The diff coverage is 13.04%.

❗ Current head 495f250 differs from pull request most recent head ec80f82. Consider uploading reports for the commit ec80f82 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1589      +/-   ##
==========================================
- Coverage   66.67%   65.29%   -1.39%     
==========================================
  Files         130      132       +2     
  Lines        2686     2746      +60     
  Branches      433      439       +6     
==========================================
+ Hits         1791     1793       +2     
- Misses        895      953      +58     
Impacted Files Coverage Δ
src/Modules.js 100.00% <ø> (ø)
src/modules/EdgeDetect/Module.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
src/modules/BlobAnalysis/Module.js 22.22% <14.28%> (-8.55%) ⬇️
src/modules/ColorHalftone/index.js 100.00% <100.00%> (ø)
src/modules/EdgeDetect/EdgeUtils.js 86.81% <100.00%> (-0.15%) ⬇️

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@gitpod-io
Copy link

gitpod-io bot commented Jul 8, 2020

@harshkhandeparkar harshkhandeparkar added this to In Progress in v3.7.0 via automation Jul 27, 2021
@harshkhandeparkar
Copy link
Member

This one's ready, just needs a review.

@jywarren jywarren removed this from In Progress in v3.7.0 Jan 25, 2022
@jywarren jywarren added this to In progress in v3.7.x via automation Jan 25, 2022
@jywarren jywarren added the bug label Jan 25, 2022
@jywarren jywarren requested a review from a team as a code owner January 25, 2022 22:57
@gitpod-io
Copy link

gitpod-io bot commented Jan 25, 2022

@jywarren jywarren merged commit 287d7e2 into publiclab:main Jan 25, 2022
v3.7.x automation moved this from In progress to Done Jan 25, 2022
@jywarren
Copy link
Member

Whew, excellent! And many thanks! Apologies for the slowness, just getting this going again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Some modules do not work in NodeJS
3 participants