Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple images show in grid #371

Closed
5 tasks
roshniRam opened this issue Oct 2, 2018 · 5 comments
Closed
5 tasks

Multiple images show in grid #371

roshniRam opened this issue Oct 2, 2018 · 5 comments

Comments

@roshniRam
Copy link

roshniRam commented Oct 2, 2018

When selecting multiple images, instead of stacking, it should be displayed in a grid.

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file $FILENAME in the $REPO repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$DIFF
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

@gitmate
Copy link

gitmate bot commented Oct 2, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #346 (Include a back-to-top Button on scrolling down), #233 (Add an "import image" module), #247 (grid of thumbnails showing step options in addStep ui), #303 (Disable/dim the Add step button until a module is selected), and #223 ((upcoming) Add "post to PublicLab.org" button to embeddable demo).

1 similar comment
@gitmate
Copy link

gitmate bot commented Oct 2, 2018

GitMate.io thinks the contributor most likely able to help you is @jywarren.

Possibly related issues are #346 (Include a back-to-top Button on scrolling down), #233 (Add an "import image" module), #247 (grid of thumbnails showing step options in addStep ui), #303 (Disable/dim the Add step button until a module is selected), and #223 ((upcoming) Add "post to PublicLab.org" button to embeddable demo).

@jywarren
Copy link
Member

jywarren commented Oct 2, 2018 via email

@gitmate gitmate bot added the enhancement label Oct 2, 2018
@roshniRam roshniRam changed the title Multiple images show in grid and add top button Multiple images show in grid Oct 2, 2018
@jywarren
Copy link
Member

Hi, @roshniRam -- would you be able to link to the lines of code which would have to change, and possibly share a screenshot of the area you'd like to invite people to adapt?

Thank you!

@roshniRam
Copy link
Author

@jywarren this issue has been fixed. Therefore, I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants