Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter-to-submit for form inputs in each step #477

Closed
jywarren opened this issue Nov 18, 2018 · 2 comments
Closed

Enter-to-submit for form inputs in each step #477

jywarren opened this issue Nov 18, 2018 · 2 comments

Comments

@jywarren
Copy link
Member

When changing the settings for a step, it would be great to be able to press return to just save the new settings:

image

But it's not set up this way currently. I believe we could wrap each in a <form> element, disable the submit action but detect onSubmit and have it save instead.... on these lines:

The per-step HTML UI code is in this file: https://github.com/publiclab/image-sequencer/blob/main/examples/lib/defaultHtmlStepUi.js

Save: https://github.com/publiclab/image-sequencer/blob/main/examples/lib/defaultHtmlStepUi.js#L122

@gitmate
Copy link

gitmate bot commented Nov 18, 2018

GitMate.io thinks possibly related issues are #459 (Close-parentheses in Dynamic module input get lost when sourced from URL), #302 (Disable/dim the Save button until step inputs have been changed), #348 (Improve Images step Ui), and #344 (Add a function to create a gif from the outputs of all steps).

1 similar comment
@gitmate
Copy link

gitmate bot commented Nov 18, 2018

GitMate.io thinks possibly related issues are #459 (Close-parentheses in Dynamic module input get lost when sourced from URL), #302 (Disable/dim the Save button until step inputs have been changed), #348 (Improve Images step Ui), and #344 (Add a function to create a gif from the outputs of all steps).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant