Close-parentheses in Dynamic module input get lost when sourced from URL

[jywarren]

The new ability to use a map() function in the Dynamic module (#457) works, but the URL gets messed up;

http://localhost:8000/examples/#steps=dynamic{red:map(r%2C0%2C255%2C0%2C128)|green:g|blue:b|monochrome%20(fallback):r%20%2B%20g%20%2B%20b}

This loses the closing ) from the map(...) function when you open it... not sure why!

image-sequencer/src/ImageSequencer.js

Lines 286 to 323 in 2243a4b

	// Converts one stringified step into JSON
	function stringToJSONstep(str) {
	var bracesStrings;
	if (str.includes('{'))
	if (str.includes('(') && str.indexOf('(') < str.indexOf('{'))
	bracesStrings = ['(', ')'];
	else
	bracesStrings = ['{', '}'];
	else
	bracesStrings = ['(', ')'];
	if (str.indexOf(bracesStrings[0]) === -1) { // if there are no settings specified
	var moduleName = str.substr(0);
	stepSettings = "";
	} else {
	var moduleName = str.substr(0, str.indexOf(bracesStrings[0]));
	stepSettings = str.slice(str.indexOf(bracesStrings[0]) + 1, -1);
	}
	stepSettings = stepSettings.split('|').reduce(function formatSettings(accumulator, current, i) {
	var settingName = current.substr(0, current.indexOf(':')),
	settingValue = current.substr(current.indexOf(':') + 1);
	settingValue = settingValue.replace(/^\(/, '').replace(/\)$/, ''); // strip () at start/end
	settingValue = settingValue.replace(/^\{/, '').replace(/\}$/, ''); // strip {} at start/end
	settingValue = decodeURIComponent(settingValue);
	current = [
	settingName,
	settingValue
	];
	if (!!settingName) accumulator[settingName] = settingValue;
	return accumulator;
	}, {});
	return {
	name: moduleName,
	options: stepSettings
	}
	}

[gitmate]

GitMate.io thinks possibly related issues are #209 (Module info in demo should source from info.json), #231 ("Save as module" button on Dynamic module), #434 (Rotate module), #112 (Scale module), and #201 (Allow easier access to neighboring pixels in Dynamic module).

[gitmate]

GitMate.io thinks possibly related issues are #209 (Module info in demo should source from info.json), #231 ("Save as module" button on Dynamic module), #434 (Rotate module), #112 (Scale module), and #201 (Allow easier access to neighboring pixels in Dynamic module).

[vibhorgupta-gh]

@jywarren Is this issue up for grabs?

[jywarren]

yes please!

…

On Wed, Dec 5, 2018 at 10:45 AM Vibhor Gupta ***@***.***> wrote: @jywarren <https://github.com/jywarren> Is this issue up for grabs? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#459 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ7o90NPbuP4kELt3ofR-gr3IEnNmks5u1-nlgaJpZM4YVUs0> .

[Divy123]

Is this issue still open? I would love to work on this.

[vibhorgupta-gh]

@Divy123 this is almost done! could you find another issue? thanks! :D

[Divy123]

yeah sure @VibhorCodecianGupta 😄

[Mridul97]

Hi, @VibhorCodecianGupta are you working on this issue? Can I work on this issue?

[vibhorgupta-gh]

@jywarren done #580